Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: nlivens <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-1246-cloudstack@git.apache.org>
In-Reply-To: <git-pr-1246-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: CLOUDSTACK-9165 unable to use reserved IP...
Content-Type: text/plain
Message-Id: <20160509141115.99BBDDFBD6@git1-us-west.apache.org>
Date: Mon,  9 May 2016 14:11:15 +0000 (UTC)
archived-at: Mon, 09 May 2016 14:11:20 -0000

Github user nlivens commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1246#discussion_r62503852
  
    --- Diff: server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java ---
    @@ -1588,6 +1588,16 @@ protected StringBuilder createGuestBootLoadArgs(final NicProfile guestNic, final
             return buf;
         }
     
    +    /**
    +     * Return a string representing network Cidr for the specifeid network
    +     * @param guestNetwork
    +     * @return valid network Cidr for the specified network
    +     */
    +    protected String getValidNetworkCidr(Network guestNetwork){
    --- End diff --
    
    I think you should extract this method to another common class (e.g. NetworkModel) since this method can be reused over the different classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---