Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: DaanHoogland <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-1532-cloudstack@git.apache.org>
In-Reply-To: <git-pr-1532-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: DAO: Hit the cache for entity flagged as ...
Content-Type: text/plain
Message-Id: <20160506155457.6DE02DFC7E@git1-us-west.apache.org>
Date: Fri,  6 May 2016 15:54:57 +0000 (UTC)
archived-at: Fri, 06 May 2016 15:54:59 -0000

Github user DaanHoogland commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1532#discussion_r62349471
  
    --- Diff: framework/db/src/com/cloud/utils/db/GenericDaoBase.java ---
    @@ -969,7 +969,12 @@ public T findByUuidIncludingRemoved(final String uuid) {
         @Override
         @DB()
         public T findByIdIncludingRemoved(ID id) {
    -        return findById(id, true, null);
    +        if (_cache != null) {
    +            final Element element = _cache.get(id);
    +            return element == null ? findById(id, true, null) : (T)element.getObjectValue();
    +        } else {
    --- End diff --
    
    yes, but I think the submitted code suggest it is optional:
    ```
    T result = findById(id, true, null)
    if (_cache != null) {
        final Element element = _cache.get(id);
        if (element != null) {
            result = (T)element.getObjectValue();
        }
    }
    return result;
    ```
    I have no problem with the proposed code if _cache is optional however.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---