Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 63EC82009F3 for ; Fri, 6 May 2016 03:06:09 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 629EF160A05; Fri, 6 May 2016 01:06:09 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A265C160A04 for ; Fri, 6 May 2016 03:06:08 +0200 (CEST) Received: (qmail 52039 invoked by uid 500); 6 May 2016 01:06:07 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 52024 invoked by uid 99); 6 May 2016 01:06:07 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 06 May 2016 01:06:07 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 2C8BDDFA3F; Fri, 6 May 2016 01:06:07 +0000 (UTC) From: dmabry To: dev@cloudstack.apache.org Reply-To: dev@cloudstack.apache.org References: In-Reply-To: Subject: [GitHub] cloudstack pull request: Marvin: Replace a timer.sleep(30) with pu... Content-Type: text/plain Message-Id: <20160506010607.2C8BDDFA3F@git1-us-west.apache.org> Date: Fri, 6 May 2016 01:06:07 +0000 (UTC) archived-at: Fri, 06 May 2016 01:06:09 -0000 Github user dmabry commented on the pull request: https://github.com/apache/cloudstack/pull/1529#issuecomment-217322431 I know it doesn't really need my LGTM, but this commit definitely improves the accuracy, and possibly the performance, of marvin and I'd personally like to see this one merged. I have run a few Marvin tests that use this code and it does work as designed. @swill CI Test good, 2+ reviews. This is Ready to Merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---