Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: jburwell <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-1529-cloudstack@git.apache.org>
In-Reply-To: <git-pr-1529-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: Marvin: Replace a timer.sleep(30) with pu...
Content-Type: text/plain
Message-Id: <20160503190541.25267DFD43@git1-us-west.apache.org>
Date: Tue,  3 May 2016 19:05:41 +0000 (UTC)
archived-at: Tue, 03 May 2016 19:05:48 -0000

Github user jburwell commented on the pull request:

    https://github.com/apache/cloudstack/pull/1529#issuecomment-216632803
  
    @mike-tutkowski you may want to consider refactoring to use the [``wait_until`` function](https://github.com/apache/cloudstack/blob/12d8e53dd54d83242b3dabf2151249ab7963d5a8/tools/marvin/marvin/lib/utils.py#L527-L543) was recently added to utils.py.   It provides a concise, Pythonic way of waiting for a condition.  For example of its usage, see the  [test_host_maintenance.py](https://github.com/apache/cloudstack/blob/12d8e53dd54d83242b3dabf2151249ab7963d5a8/test/integration/component/test_host_maintenance.py#L181) where it is used to wait until VM migration has completed before proceeding with the test.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---