Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 05FC1200A01 for ; Tue, 3 May 2016 17:45:41 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 0570D1609F4; Tue, 3 May 2016 17:45:41 +0200 (CEST) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 460F11609A9 for ; Tue, 3 May 2016 17:45:40 +0200 (CEST) Received: (qmail 81569 invoked by uid 500); 3 May 2016 15:45:39 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 81547 invoked by uid 99); 3 May 2016 15:45:39 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 May 2016 15:45:39 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id B28E0DFD7B; Tue, 3 May 2016 15:45:38 +0000 (UTC) From: GabrielBrascher To: dev@cloudstack.apache.org Reply-To: dev@cloudstack.apache.org References: In-Reply-To: Subject: [GitHub] cloudstack pull request: [4.7] vmware: improve support for disks Content-Type: text/plain Message-Id: <20160503154538.B28E0DFD7B@git1-us-west.apache.org> Date: Tue, 3 May 2016 15:45:38 +0000 (UTC) archived-at: Tue, 03 May 2016 15:45:41 -0000 Github user GabrielBrascher commented on the pull request: https://github.com/apache/cloudstack/pull/1365#issuecomment-216571886 @swill I haven't worked much on that file (I had fixed a typo in the name of the "ROOT_DISK_CONTROLLER" variable). At the first look I would agree with @mike-tutkowski, but I have a limited background on this file. I need to look with more care to be helpful. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---