Return-Path: <dev-return-93495-archive-asf-public=cust-asf.ponee.io@cloudstack.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id C28302009D9
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Mon,  2 May 2016 23:18:26 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id C11AA1609B0; Mon,  2 May 2016 23:18:26 +0200 (CEST)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 15FBC1602C5
	for <archive-asf-public@cust-asf.ponee.io>; Mon,  2 May 2016 23:18:25 +0200 (CEST)
Received: (qmail 65899 invoked by uid 500); 2 May 2016 21:18:25 -0000
Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@cloudstack.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@cloudstack.apache.org>
List-Post: <mailto:dev@cloudstack.apache.org>
List-Id: <dev.cloudstack.apache.org>
Reply-To: dev@cloudstack.apache.org
Delivered-To: mailing list dev@cloudstack.apache.org
Received: (qmail 65884 invoked by uid 99); 2 May 2016 21:18:24 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 May 2016 21:18:24 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id A868DDFC55; Mon,  2 May 2016 21:18:24 +0000 (UTC)
From: jburwell <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-1502-cloudstack@git.apache.org>
In-Reply-To: <git-pr-1502-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...
Content-Type: text/plain
Message-Id: <20160502211824.A868DDFC55@git1-us-west.apache.org>
Date: Mon,  2 May 2016 21:18:24 +0000 (UTC)
archived-at: Mon, 02 May 2016 21:18:26 -0000

Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1502#discussion_r61806348
  
    --- Diff: api/src/org/apache/cloudstack/outofbandmanagement/OutOfBandManagementService.java ---
    @@ -0,0 +1,51 @@
    +// Licensed to the Apache Software Foundation (ASF) under one
    +// or more contributor license agreements.  See the NOTICE file
    +// distributed with this work for additional information
    +// regarding copyright ownership.  The ASF licenses this file
    +// to you under the Apache License, Version 2.0 (the
    +// "License"); you may not use this file except in compliance
    +// with the License.  You may obtain a copy of the License at
    +//
    +//   http://www.apache.org/licenses/LICENSE-2.0
    +//
    +// Unless required by applicable law or agreed to in writing,
    +// software distributed under the License is distributed on an
    +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +// KIND, either express or implied.  See the License for the
    +// specific language governing permissions and limitations
    +// under the License.
    +package org.apache.cloudstack.outofbandmanagement;
    +
    +import com.cloud.dc.DataCenter;
    +import com.cloud.host.Host;
    +import com.cloud.org.Cluster;
    +import com.google.common.collect.ImmutableMap;
    +import org.apache.cloudstack.api.response.OutOfBandManagementResponse;
    +import org.apache.cloudstack.framework.config.ConfigKey;
    +
    +import java.util.List;
    +
    +public interface OutOfBandManagementService {
    +
    +    ConfigKey<Long> OutOfBandManagementActionTimeout = new ConfigKey<Long>("Advanced", Long.class, "outofbandmanagement.action.timeout", "60",
    +                    "The out of band management action timeout in seconds, configurable by cluster", true, ConfigKey.Scope.Cluster);
    +
    +    ConfigKey<Long> OutOfBandManagementSyncThreadInterval = new ConfigKey<Long>("Advanced", Long.class, "outofbandmanagement.sync.interval", "300000",
    +            "The interval (in milliseconds) when the out-of-band management background sync are retrieved", true, ConfigKey.Scope.Global);
    +
    +    ConfigKey<Integer> OutOfBandManagementSyncThreadPoolSize = new ConfigKey<Integer>("Advanced", Integer.class, "outofbandmanagement.sync.poolsize", "50",
    +            "The out of band management background sync thread pool size", true, ConfigKey.Scope.Global);
    +
    +    long getId();
    +    boolean isOutOfBandManagementEnabled(Host host);
    +    void submitBackgroundPowerSyncTask(Host host);
    +    boolean transitionPowerStateToDisabled(List<? extends Host> hosts);
    --- End diff --
    
    Why is ``hosts`` declared as ``List<? extends Host>`` rather than ``List<Host>``?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---