Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: DaanHoogland <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-1365-cloudstack@git.apache.org>
In-Reply-To: <git-pr-1365-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: [4.7] vmware: improve support for disks
Content-Type: text/plain
Message-Id: <20160502142140.A6EC9DFC6C@git1-us-west.apache.org>
Date: Mon,  2 May 2016 14:21:40 +0000 (UTC)
archived-at: Mon, 02 May 2016 14:21:48 -0000

Github user DaanHoogland commented on the pull request:

    https://github.com/apache/cloudstack/pull/1365#issuecomment-216248411
  
    did a code walk through and saw no extravaganzas and some useful extractions and renamings. As for the functionality, I have no clue. I am not a vmware user, let alone expert but for what it's worth: LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---