Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: "Tutkowski, Mike" <Mike.Tutkowski@netapp.com>
To: "dev@cloudstack.apache.org" <dev@cloudstack.apache.org>
Subject: Re: Variable renaming in classes meant for Agents
Thread-Topic: Variable renaming in classes meant for Agents
Thread-Index: AQHRslK9TQEm0oVPdUGKNw0ZSuI2oJ/BQVAr
Date: Fri, 20 May 2016 04:53:23 +0000
Message-ID: <1463720005877.40747@netapp.com>
References: <3497C24D-C446-4068-A156-D1920DA05848@persistent.co.in>
In-Reply-To: <3497C24D-C446-4068-A156-D1920DA05848@persistent.co.in>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
archived-at: Fri, 20 May 2016 04:53:34 -0000

Thanks for sending out this e-mail, Anshul.=0A=
=0A=
This is a bit of a strange situation because we need to make sure people ar=
e either aware of the fact that properties in Command classes are serialize=
d (and not change existing variable names) or come up with a less fragile w=
ay of choosing property names when sending data (perhaps using annotations)=
.=0A=
=0A=
At the very least, we should have comments in these classes indicating the =
dangers of changing property names. It might also be beneficial to have uni=
t tests in place that expect certain variable names and assert if they are =
not as expected.=0A=
=0A=
In the meanwhile, I plan to change the variable names back that were change=
d in PR #816.=0A=
=0A=
Additional thoughts on how this should be addressed long term?=0A=
=0A=
Thanks!=0A=
Mike=0A=
________________________________________=0A=
From: Anshul Gangwar <anshul.gangwar@accelerite.com>=0A=
Sent: Thursday, May 19, 2016 10:47 PM=0A=
To: dev@cloudstack.apache.org=0A=
Subject: Variable renaming in classes meant for Agents=0A=
=0A=
Hi,=0A=
=0A=
We should not allow renaming of variables in classes which ends with Comman=
d and TO. As these objects are meant to be consumed by Agents.=0A=
=0A=
Agents may not be written in java so relying on these variable names to get=
 the info. One such example is Hyper-V agent.=0A=
=0A=
Hyper-V support is currently broken as there are some variables renamed in =
PR https://github.com/apache/cloudstack/pull/816.=0A=
=0A=
Regards,=0A=
Anshul=0A=
=0A=
=0A=
=0A=
=0A=
=0A=
=0A=
DISCLAIMER=0A=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=0A=
This e-mail may contain privileged and confidential information which is th=
e property of Accelerite, a Persistent Systems business. It is intended onl=
y for the use of the individual or entity to which it is addressed. If you =
are not the intended recipient, you are not authorized to read, retain, cop=
y, print, distribute or use this message. If you have received this communi=
cation in error, please notify the sender and delete all copies of this mes=
sage. Accelerite, a Persistent Systems business does not accept any liabili=
ty for virus infected mails.=0A=