cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sanju1010 <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Changing vlan to None since network offer...
Date Mon, 30 May 2016 11:33:22 GMT
GitHub user sanju1010 opened a pull request:

    https://github.com/apache/cloudstack/pull/1571

    Changing vlan to None since network offering being used has Specify Vlan set to No

    Default isolated network offering with SourceNat service has Specify Vlan parameter set
to No. When specify vlan is "No" we can't pass vlan number for network creation api. Three
tests are passing vlan id. Hence setting it to None.
    
    Test results:
    ==========
    # Validate that Admin should be able to create network for himslef ... === TestName: test_01_createNetwork_admin
| Status : SUCCESS ===
    ok
    # Validate that Admin should be able to create network for users in his domain ... ===
TestName: test_02_createNetwork_admin_foruserinsamedomain | Status : SUCCESS ===
    ok
    # Validate that Admin should be able to create network for users in his sub domain ...
=== TestName: test_03_createNetwork_admin_foruserinotherdomain | Status : SUCCESS ===
    ok
    
    ----------------------------------------------------------------------
    Ran 3 tests in 440.959s
    
    OK


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sanju1010/cloudstack acl

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1571.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1571
    
----
commit 9de8353aa2ae53d8e41b23b689b98e8885930cfb
Author: sanjeev <sanjeev.neelarapu@accelerite.com>
Date:   2016-05-30T11:22:09Z

    Changing vlan to None since network offering being used has Specify Vlan set to No

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message