cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nvazquez <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9368: DS template copies donâ€...
Date Tue, 24 May 2016 19:34:48 GMT
GitHub user nvazquez opened a pull request:

    https://github.com/apache/cloudstack/pull/1560

    CLOUDSTACK-9368: DS template copies don’t get deleted in VMware ESXi with multiple clusters
and zone wide storage

    JIRA TICKET: https://issues.apache.org/jira/browse/CLOUDSTACK-9386
    
    ### Introduction
    In some production environments with multiple clusters it was noticed that unused templates
were consuming too much storage. It was discovered that template cleanup was not deleting
marked templates on ESXi.
    
    ### Description of the problem
    Suppose we have multiple clusters `(c1, c2,...,cN)` on a data center and template `T`
from which we deploy vms on `c1.`
    Suppose now that we expunge those vms, and there's no other vm instance from template
`T,` so this was the actual workflow:
    
    1. CloudStack marks template for cleanup after `storage.cleanup.interval` seconds, by
setting `marked_for_gc = 1` on `template_spool_ref` table, for that template.
    
    2. After another `storage.cleanup.interval` seconds a `DestroyCommand` will be sent, to
delete template from primary storage
    
    3. On `VmwareResource`, command is processed, and it first picks up a random cluster,
say `ci != c1` to look for vm template (using volume's path) and destroy it. But, as template
was on `c1` it cannot be found, so it won't be deleted. Entry on `template_spool_ref` is deleted
but not the actual template on hypervisor side.
    
    ### Proposed solution
    We propose a way to attack problem shown in point 3, by not picking up a random cluster
to look for vm but using data store. This way we make sure vm template will be deleted in
every case, and not depending on random cluster selection

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nvazquez/cloudstack gcbug

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1560.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1560
    
----
commit 656bba0cc3281d40c2609eafc0f7ae691a8863e8
Author: nvazquez <nicolas.m.vazquez@gmail.com>
Date:   2016-05-20T16:01:03Z

    CLOUDSTACK-9368: Find vm on datacenter instead of randomly choosing a cluster

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message