cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rodrigo93 <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Removed unused methods from XenServerConn...
Date Sat, 21 May 2016 23:43:47 GMT
GitHub user rodrigo93 opened a pull request:

    https://github.com/apache/cloudstack/pull/1557

    Removed unused methods from XenServerConnectionPool

    Removed the following methods that are unused from the class
    _com.cloud.hypervisor.xenserver.resource.XenServerConnectionPool_:
    - static void **forceSleep**(long sec)		
    - protected Session **slaveLocalLoginWithPassword**(Connection conn, String
    username, Queue<String> password)	
    - static public Pool.Record **getPoolRecord**(Connection conn) throws
    XmlRpcException, XenAPIException
    
    From XenServerConnectionPool.XenServerConnection:
    - public String getUsername()
    - public Queue<String> getPassword()		
    - protected Map dispatch(String methodcall, Object[] methodparams)
    		
    I would like to make a note about the "TrustAllManager" static class
    inside the XenServerConnectionPool class. I noticed methods from TrustAllManager class
returns true or "nothing". This can be a security problem, since it returns true without any
    verification.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rodrigo93/cloudstack lrg-cs-hackday-027

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1557.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1557
    
----
commit dd5c9d03b3b14de13711fda6c5c4eb5ee841ef42
Author: Rodrigo Marques <rodrigomarques1993@gmail.com>
Date:   2016-05-22T02:34:14Z

    Removed unused methods from XenServerConnectionPool
    
    Removed unused methods from the class
    com.cloud.hypervisor.xenserver.resource.XenServerConnectionPool:
    		
    static void forceSleep(long sec)
    		
    protected Session slaveLocalLoginWithPassword(Connection conn, String
    username, Queue<String> password)
    		
    static public Pool.Record getPoolRecord(Connection conn) throws
    XmlRpcException, XenAPIException
    		
    Inside XenServerConnectionPool.XenServerConnection
    		public String getUsername()
    		
    		public Queue<String> getPassword()
    		
    		protected Map dispatch(String methodcall, Object[] methodparams)
    		
    I would like to make a note about the "TrustAllManager" static class
    inside the XenServerConnectionPool class.
    I noticed the methods from TrustAllManager returns true or nothing. This
    can be a security problem, since it returns true without any
    verification.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message