cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rhtyd <...@git.apache.org>
Subject [GitHub] cloudstack pull request: dynamic-roles: remove unnecessary order b...
Date Wed, 18 May 2016 08:17:55 GMT
GitHub user rhtyd opened a pull request:

    https://github.com/apache/cloudstack/pull/1551

    dynamic-roles: remove unnecessary order by ID

    On some MySQL server envs, this may cause a SQL statement error, though
    I was unable to reproduce it. Since it's not needed, an order by 'sort_order'
    is enough, we can safely remove it.
    
    /cc @swill @anshulgangwar @DaanHoogland and others

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shapeblue/cloudstack rbac-mysql-fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1551.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1551
    
----
commit 1770f3cb86f84128c40571330af55a7255fa49cc
Author: Rohit Yadav <rohit.yadav@shapeblue.com>
Date:   2016-05-18T08:16:18Z

    dynamic-roles: remove unnecessary order by ID
    
    On some MySQL server envs, this may cause a SQL statement error, though
    I was unable to reproduce it. Since it's not needed, an order by 'sort_order'
    is enough, we can safely remove it.
    
    Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message