cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From marcaurele <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9238: Increase URL fields to 2...
Date Fri, 27 May 2016 06:03:49 GMT
Github user marcaurele commented on the pull request:

    https://github.com/apache/cloudstack/pull/1341#issuecomment-222067277
  
    Hi! Talking with @footplus on the mailing list, I realized that this patch is not correct.
It's missing modifications on the VO objects to let the String holds more than 255 characters
because in the `GenericDaoBase`, `String` fields are by default of 255 chars, see:
    https://github.com/apache/cloudstack/blob/master/framework/db/src/com/cloud/utils/db/GenericDaoBase.java#L1510
    
    This PR should be updated, or should there be a new one to add those changes?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message