cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GabrielBrascher <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...
Date Fri, 20 May 2016 17:35:06 GMT
Github user GabrielBrascher commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1494#discussion_r64078451
  
    --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java
---
    @@ -270,15 +258,15 @@ public PingCommand getCurrentStatus(long id) {
                 _shouldAudit = true;
                 return null;
             }
    -        if (_cmsUserInfo == null || _cmsUserInfo.length < 2) {
    +        if (_cmsUserLogin == null || _cmsUserLogin.isEmpty() || _cmsUserPassword == null
|| _cmsUserPassword.isEmpty()) {
    --- End diff --
    
    @nlivens you can use StringUtils.isEmpty(CharString cs) [https://commons.apache.org/proper/commons-lang/apidocs/org/apache/commons/lang3/StringUtils.html]
in order to check if a String is empty or null.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message