cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaanHoogland <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Explicitely load JDBC driver before creat...
Date Fri, 20 May 2016 13:27:35 GMT
Github user DaanHoogland commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1553#discussion_r64040574
  
    --- Diff: framework/db/src/com/cloud/utils/db/TransactionLegacy.java ---
    @@ -1014,6 +1014,13 @@ public static void initDataSource(Properties dbProps) {
                 if (dbProps.size() == 0)
                     return;
     
    +            try {
    +                // Explicitely load JDBC driver because it has been removed from the
classpath as part of commit c22659d76d73f00f41c13776c490e17a50aacd20
    +                Class.forName("com.mysql.jdbc.Driver");
    --- End diff --
    
    two questions:
    hardcoded driver name?; now that we can shouldn't we prepare for a MariaDB driver to be
loaded instead?
    if it is not on the classpath how is this going to help, then? Class.forName(..) will
search the classpath


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message