cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaanHoogland <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Made the adding new keyboard language sup...
Date Thu, 19 May 2016 22:02:34 GMT
Github user DaanHoogland commented on the pull request:

    https://github.com/apache/cloudstack/pull/669#issuecomment-220464828
  
    Really like the functionality so I think we must get this in. I have some remarks about
the code that I stand by even though they are not entirely to blame on @anshul1886 as he calls
methods fthrowing Exception, rom SshHelper mainly. It is a bad smell due to the older code
and will not facilitate trouble shooting for the end user. So I would like to see the exception-handlers
be enriched with some better diagnosis and *maybe* messages. nothing else to nag about.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message