cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rhtyd <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8715: Add channel to Instances...
Date Thu, 19 May 2016 09:49:50 GMT
Github user rhtyd commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1545#discussion_r63850379
  
    --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
---
    @@ -1978,11 +1978,16 @@ So if getMinSpeed() returns null we fall back to getSpeed().
             final SerialDef serial = new SerialDef("pty", null, (short)0);
             devices.addDevice(serial);
     
    +        /* Add a VirtIO channel for SystemVMs for communication and provisioning */
             if (vmTO.getType() != VirtualMachine.Type.User) {
    -            final VirtioSerialDef vserial = new VirtioSerialDef(vmTO.getName(), null);
    -            devices.addDevice(vserial);
    +            devices.addDevice(new ChannelDef(vmTO.getName() + ".vport", ChannelDef.ChannelType.UNIX,
    +                                             "/var/lib/libvirt/qemu/" + vmTO.getName()
+ ".agent"));
             }
     
    +        /* Add a VirtIO channel for the Qemu Guest Agent tools */
    +        devices.addDevice(new ChannelDef("org.qemu.guest_agent.0", ChannelDef.ChannelType.UNIX,
    +                                         "/var/lib/libvirt/qemu/" + vmTO.getName() +
".org.qemu.guest_agent.0"));
    --- End diff --
    
    We're hardcoding channel type `unix` here, is that the default or should we allow users
to choose between unix, serial and others? Also, about the guest agent name, while `/var/lib/libvirt/qemu`
is the default path on most distros we should make it configurable or make it detect the path
based on the env.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message