cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rhtyd <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8715: Add channel to Instances...
Date Thu, 19 May 2016 09:46:07 GMT
Github user rhtyd commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1545#discussion_r63849902
  
    --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtDomainXMLParser.java
---
    @@ -171,6 +173,25 @@ public boolean parseDomainXML(String domXML) {
                     interfaces.add(def);
                 }
     
    +            NodeList ports = devices.getElementsByTagName("channel");
    +            for (int i = 0; i < ports.getLength(); i++) {
    +                Element channel = (Element)ports.item(i);
    +
    +                String type = channel.getAttribute("type");
    +                String path = getAttrValue("source", "path", channel);
    +                String name = getAttrValue("target", "name", channel);
    +                String state = getAttrValue("target", "state", channel);
    +
    +                ChannelDef def = null;
    +                if (state == null || state.length() == 0) {
    --- End diff --
    
    we can use Strings.isNullOrEmpty here


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message