cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaanHoogland <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Fixes for VirtualRouters in Basic Network...
Date Wed, 18 May 2016 12:20:12 GMT
Github user DaanHoogland commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1547#discussion_r63692269
  
    --- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsConfig.py ---
    @@ -82,7 +82,10 @@ def get_dns(self):
             conf = self.cmdline().idata()
             dns = []
             if not self.use_extdns():
    -            dns.append(self.address().get_guest_ip())
    +            if not self.is_vpc() and self.cl.is_redundant() and self.cl.get_guest_gw():
    --- End diff --
    
    so this would treat isolated and shared networks alike. Is that acceptable @ustcweizhou
?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message