cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From The-Loeki <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Fixes for VirtualRouters in Basic Network...
Date Wed, 18 May 2016 11:55:06 GMT
Github user The-Loeki commented on the pull request:

    https://github.com/apache/cloudstack/pull/1547#issuecomment-220004141
  
    @linas-h1p thanks for noticing, that fix got lost in commit msg translation.
    
    I've amended the `CsAddress.py` commit to (un)fix the whitespacing & readded the `arpPing()`
fix which caused your `KeyError`.
    
    The `ipaliases` stuff is for Pods which have multiple IP ranges in the same Guest VLAN,
which is at least a Basic Networking feature.
    They indeed don't bring a `gateway` key with them, but CS assumes there is one to ping
to verify the connection is up.
    
    By adding this tweak and reformatting the `ipalias.json` the ip aliases are now processed
by the same code which adds & removes addresses, which prevents code duplication and additional
files & bugs.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message