cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From The-Loeki <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Fixes for VirtualRouters in Basic Network...
Date Tue, 17 May 2016 15:26:47 GMT
Github user The-Loeki commented on the pull request:

    https://github.com/apache/cloudstack/pull/1547#issuecomment-219754165
  
    Maybe, but for now it's still just one conditional which needs just one decision/explanation.

    On the plus side, if the decision can be taken in CsConfig correctly and CsGuestNetwork
can employ the same logic this reduces code duplication and improves the overall quality.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message