cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GabrielBrascher <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...
Date Sat, 14 May 2016 20:00:16 GMT
Github user GabrielBrascher commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1518#discussion_r63281205
  
    --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
    @@ -519,6 +523,64 @@ public Answer executeRequest(Command cmd) {
         }
     
         /**
    +     * Check if storage NFS version is already set or needs to be reconfigured.<br>
    +     * If _storageNfsVersion is not null -> nothing to do, version already set.<br>
    +     * If _storageNfsVersion is null -> examine StorageSubSystemCommand to get NFS
version and set it
    +     * to the storage processor and storage handler.
    +     * @param cmd command to execute
    +     */
    +    protected void checkStorageProcessorAndHandlerNfsVersionAttribute(StorageSubSystemCommand
cmd) {
    +        if (_storageNfsVersion != null) return;
    +        if (cmd instanceof CopyCommand){
    +            examineStorageSubSystemCommandNfsVersion((CopyCommand) cmd);
    +        }
    +    }
    +
    +    /**
    +     * Examine StorageSubSystem command to get storage NFS version, if provided
    +     * @param cmd command to execute
    +     */
    +    protected void examineStorageSubSystemCommandNfsVersion(CopyCommand cmd){
    +        DataStoreTO srcDataStore = cmd.getSrcTO().getDataStore();
    +        boolean nfsVersionFound = false;
    +
    +        if (srcDataStore instanceof NfsTO){
    +            nfsVersionFound = getStorageNfsVersionFromNfsTO((NfsTO) srcDataStore);
    +        }
    +
    +        if (nfsVersionFound){
    +            setCurrentNfsVersionInProcessorAndHandler();
    +        }
    +    }
    +
    +    /**
    +     * Get storage NFS version from NfsTO
    +     * @param nfsTO nfsTO
    +     * @return true if NFS version if found and not null, false in other case
    --- End diff --
    
    @nvazquez just a small typo, change "_true if NFS version **if** found_" to "_true if
NFS version **was** found_".
    Good job with the code documentation, thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message