cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mike-tutkowski <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...
Date Fri, 13 May 2016 20:06:54 GMT
Github user mike-tutkowski commented on the pull request:

    https://github.com/apache/cloudstack/pull/1403#issuecomment-219146275
  
    @jburwell @DaanHoogland I have a solution for quickly looking up if a cluster supports
resigning that I think we'll all be happy with.
    
    Upon a host connecting to the management server is when I check to see if the host supports
resigning (and update the host_details table).
    
    I added logic to this connection code to not only update the host_details table with info
about resigning, but also the cluster_details table about resigning.
    
    A host connecting to the management server should not be a frequent occurrence, so I believe
it's OK at this point to run through the list of hosts in the cluster of the connecting host
and see if all of those hosts support resigning. If they do, then I update the cluster_details
table that the cluster in question supports resigning.
    
    I also changed the logic to not bother to add a row to either the host_details table or
the cluster_details table if the "supportsResign" property would be false (only a true value
is stored now). We can then save space by understanding that a missing "supportsResign" property
for a host or cluster indicates false (I was proceeding under that assumption anyways).
    
    When the time comes to ask the cluster if it supports resigning, it's a simple matter
of looking for the "supportsResign" property in the cluster_details table.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message