cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rhtyd <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9348: Make NioConnectio loop l...
Date Fri, 13 May 2016 03:28:30 GMT
Github user rhtyd commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1543#discussion_r63129136
  
    --- Diff: utils/src/main/java/com/cloud/utils/nio/Link.java ---
    @@ -615,7 +615,10 @@ public static boolean doHandshake(final SocketChannel socketChannel,
final SSLEn
                     case NEED_TASK:
                         Runnable task;
                         while ((task = sslEngine.getDelegatedTask()) != null) {
    -                        new Thread(task).run();
    +                        if (s_logger.isTraceEnabled()) {
    +                            s_logger.trace("SSL: Running delegated task!");
    +                        }
    +                        task.run();
    --- End diff --
    
    @jburwell thanks for pointing out, I've made the runnable task run in the current thread
only. The delegated tasks in case of SSL handshake could be resolving domain names to address.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message