cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaanHoogland <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...
Date Thu, 12 May 2016 19:41:27 GMT
Github user DaanHoogland commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1403#discussion_r63083834
  
    --- Diff: engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java
---
    @@ -289,7 +291,7 @@ public boolean deleteSnapshot(Long snapshotId) {
         @Override
         public boolean revertSnapshot(SnapshotInfo snapshot) {
             if (canHandle(snapshot,SnapshotOperation.REVERT) == StrategyPriority.CANT_HANDLE)
{
    -            throw new UnsupportedOperationException("Reverting not supported. Create
a template or volume based on the snapshot instead.");
    +            throw new CloudRuntimeException("Reverting not supported. Create a template
or volume based on the snapshot instead.");
    --- End diff --
    
    @jburwell want to discuss?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message