cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GabrielBrascher <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-6928: fix issue disk I/O throt...
Date Thu, 12 May 2016 18:49:46 GMT
Github user GabrielBrascher commented on the pull request:

    https://github.com/apache/cloudstack/pull/1410#issuecomment-218850613
  
    @DaanHoogland @ustcweizhou I noticed that there is four 'if' with the condition `(io !=
null) && (io > 0)` at the _KVMStorageProcessor_ class (lines 1009 - 1019). It migh
be interesting to create a method isIORateNotNullAndBiggerThanZero, like:
    
    `public boolean isIORateNotNullAndBiggerThanZero(Long io) {`
     `return (io != null) && (io > 0);`
    `}`
    
    And then use `if(isIORateNotNullAndBiggerThanZero(io)) {...}`.
    But it is no big deal for me. It is more a sugestion of cosmetic changes, nothing serious
to stuck this PR.
    
    Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message