cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From swill <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9378: Fix for #1497
Date Thu, 12 May 2016 12:30:05 GMT
Github user swill commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1539#discussion_r63011147
  
    --- Diff: test/integration/smoke/test_list_ids_parameter.py ---
    @@ -194,10 +194,7 @@ def setUpClass(cls):
             cls._cleanup = [
                             cls.disk_offering,
                             cls.account,
    -                        cls.service_offering,
    -                        cls.snapshot_1,
    -                        cls.snapshot_2,
    -                        cls.snapshot_3
    +                        cls.service_offering
    --- End diff --
    
    I agree with your order.  @nvazquez can you update the order to what rohit posted in his
commit.  @rhtyd is there a reason you added this to your PR?  Will you just remove it from
that PR once this is updated and merged?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message