cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaanHoogland <>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9378: Fix for #1497
Date Thu, 12 May 2016 09:59:50 GMT
Github user DaanHoogland commented on a diff in the pull request:
    --- Diff: test/integration/smoke/ ---
    @@ -194,10 +194,7 @@ def setUpClass(cls):
             cls._cleanup = [
    -                        cls.service_offering,
    -                        cls.snapshot_1,
    -                        cls.snapshot_2,
    -                        cls.snapshot_3
    +                        cls.service_offering
    --- End diff --
    I would say that cleanup should happen in reverse order of creation, irrespective of ownership.
Leaving these items after an integration test while other tests may follow seems like a bad

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message