cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaanHoogland <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9287 - Fix unique mac address ...
Date Thu, 12 May 2016 08:58:44 GMT
Github user DaanHoogland commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1483#discussion_r62985942
  
    --- Diff: server/src/com/cloud/network/element/VpcVirtualRouterElement.java ---
    @@ -466,7 +466,7 @@ public boolean deletePrivateGateway(final PrivateGateway gateway)
throws Concurr
                 }
             }
     
    -        return result > 0 ? true : false;
    +        return result == routers.size() ? true : false;
         }
    --- End diff --
    
    @alexandrelimassantana This code is not very new, please write a little pull request to
that extend. (also the issue that you quite justly pointed out is there in the old code as
well and bears no weight on the validity of this PR)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message