cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaanHoogland <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...
Date Wed, 11 May 2016 17:02:20 GMT
Github user DaanHoogland commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1403#discussion_r62886063
  
    --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
---
    @@ -1792,10 +1796,26 @@ protected void fillHostInfo(final Connection conn, final StartupRoutingCommand
c
                 cmd.setPod(_pod);
                 cmd.setVersion(CitrixResourceBase.class.getPackage().getImplementationVersion());
     
    +            try {
    +                final String cmdLine = "xe sm-list | grep \"resigning of duplicates\"";
    +
    +                final XenServerUtilitiesHelper xenServerUtilitiesHelper = getXenServerUtilitiesHelper();
    +
    +                Pair<Boolean, String> result = xenServerUtilitiesHelper.executeSshWrapper(_host.getIp(),
22, _username, null, getPwdFromQueue(), cmdLine);
    +
    +                boolean supportsClonedVolumes = result != null && result.first()
!= null && result.first() &&
    +                        result.second() != null && result.second().length() >
0;
    +
    +                cmd.setSupportsClonedVolumes(supportsClonedVolumes);
    +            } catch (Exception ex) {
    --- End diff --
    
    no checked exceptions are being thrown, why a catch all? is there a specific exception
that might threaten us?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message