cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaanHoogland <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...
Date Wed, 11 May 2016 16:57:35 GMT
Github user DaanHoogland commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1403#discussion_r62885313
  
    --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
---
    @@ -164,9 +165,12 @@
      *
      */
     public abstract class CitrixResourceBase implements ServerResource, HypervisorResource,
VirtualRouterDeployer {
    -
    +    /**
    +     * RELVMOISCSI = used for resigning metadata (like SR UUID and VDI UUID when a
    +     * particular storage manager is installed on a XenServer host (for back-end snapshots
to work))
    +     */
    --- End diff --
    
    I would put the value javadoc on the value and describe only the whole enum here. (PR
coming to that end on another enum, shortly)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message