cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rhtyd <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...
Date Wed, 11 May 2016 04:37:43 GMT
Github user rhtyd commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1502#discussion_r62790877
  
    --- Diff: utils/src/main/java/org/apache/cloudstack/utils/process/ProcessRunner.java ---
    @@ -0,0 +1,112 @@
    +//
    +// Licensed to the Apache Software Foundation (ASF) under one
    +// or more contributor license agreements.  See the NOTICE file
    +// distributed with this work for additional information
    +// regarding copyright ownership.  The ASF licenses this file
    +// to you under the Apache License, Version 2.0 (the
    +// "License"); you may not use this file except in compliance
    +// with the License.  You may obtain a copy of the License at
    +//
    +//   http://www.apache.org/licenses/LICENSE-2.0
    +//
    +// Unless required by applicable law or agreed to in writing,
    +// software distributed under the License is distributed on an
    +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +// KIND, either express or implied.  See the License for the
    +// specific language governing permissions and limitations
    +// under the License.
    +//
    +
    +package org.apache.cloudstack.utils.process;
    +
    +import com.cloud.utils.concurrency.NamedThreadFactory;
    +import com.google.common.base.Preconditions;
    +import com.google.common.base.Strings;
    +import org.apache.log4j.Logger;
    +import org.joda.time.Duration;
    +
    +import java.io.BufferedReader;
    +import java.io.IOException;
    +import java.io.InputStream;
    +import java.io.InputStreamReader;
    +import java.util.List;
    +import java.util.concurrent.Callable;
    +import java.util.concurrent.ExecutionException;
    +import java.util.concurrent.ExecutorService;
    +import java.util.concurrent.Executors;
    +import java.util.concurrent.Future;
    +import java.util.concurrent.TimeUnit;
    +import java.util.concurrent.TimeoutException;
    +
    +public class ProcessRunner {
    +    public static final Logger LOG = Logger.getLogger(ProcessRunner.class);
    +
    +    private static final ExecutorService processExecutor = Executors.newCachedThreadPool(new
NamedThreadFactory("ProcessRunner"));
    +
    +    private static String readStream(final InputStream inputStream) {
    +        String text = null;
    +        try {
    +            final BufferedReader bufferedReader = new BufferedReader(new InputStreamReader(inputStream));
    +            String line;
    +            while ((line = bufferedReader.readLine()) != null) {
    +                if (Strings.isNullOrEmpty(text)) {
    +                    text = line;
    +                } else {
    +                    text = text + "\n" + line;
    +                }
    +            }
    +        } catch (IOException e) {
    +            if (LOG.isTraceEnabled()) {
    +                LOG.trace("ProcessRunner::readStream failed due to: " + e.getMessage());
    +            }
    +        }
    +        return text;
    +    }
    +
    +    public static ProcessResult executeCommands(final List<String> commands, final
Duration timeOut) {
    +        Preconditions.checkArgument(commands != null && timeOut != null);
    +
    +        int retVal = -2;
    +        String stdOutput = null;
    +        String stdError = null;
    +
    +        try {
    +            final Process process = new ProcessBuilder().command(commands).start();
    +            if (timeOut.getStandardSeconds() > 0) {
    --- End diff --
    
    @jburwell ipmitool driver does not execute the command with a timeout, the utility needs
to be generic which is why an option is provided to no consider timeout (0 = no timeout).
The users of the utility need to make the decision and not this utility. For certain cases,
it may be acceptable to execute a process without any time boundary therefore the utility
should allow for both use-cases.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message