cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <...@git.apache.org>
Subject [GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...
Date Wed, 11 May 2016 02:16:47 GMT
Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1371#discussion_r62783518
  
    --- Diff: server/src/org/apache/cloudstack/network/topology/BasicNetworkVisitor.java ---
    @@ -316,4 +317,9 @@ public boolean visit(final StaticRoutesRules staticRoutesRules) throws
ResourceU
         public boolean visit(final AdvancedVpnRules vpnRules) throws ResourceUnavailableException
{
             throw new CloudRuntimeException("AdvancedVpnRules not implemented in Basic Network
Topology.");
         }
    +
    +    @Override
    +    public boolean visit(final QuaggaRules vpnRules) throws ResourceUnavailableException
{
    +        throw new CloudRuntimeException("AdvancedVpnRules not implemented in Basic Network
Topology.");
    --- End diff --
    
    Consider using the ``OperationNotSupported`` exception provided by the Java runtime for
this purpose.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message