cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <...@git.apache.org>
Subject [GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...
Date Wed, 11 May 2016 02:00:22 GMT
Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1371#discussion_r62782579
  
    --- Diff: server/src/com/cloud/network/vpc/VpcManagerImpl.java ---
    @@ -747,6 +810,67 @@ public VpcOffering updateVpcOffering(final long vpcOffId, final String
vpcOfferi
         }
     
         @Override
    +    public CIDR[] getZoneSuperCidrList(final long zoneId) throws BadCIDRException {
    +        final String superCIDRList = _dcDao.getDetail(zoneId, Params.SUPER_CIDR.name());
    +        if (superCIDRList != null) {
    +            String[] str_cidr_list = superCIDRList.split(",");
    +            CIDR[] cidr_list = NetUtils.convertToCIDR(str_cidr_list);
    +            if (!NetUtils.cidrListConsistency(cidr_list)) {
    +                throw new InvalidParameterValueException("The cidr list is not consistent
" + Arrays.toString(cidr_list));
    +            }
    +            return cidr_list;
    +        } else {
    +            throw new InvalidParameterValueException("Zone super cidr is null check cloud.data_center_details
for zone id=" + zoneId);
    +        }
    +    }
    +
    +    private List<CIDR> getAllVpcCidrs() throws BadCIDRException {
    +        // get all the used cidrs
    +        List<CIDR> usedSubnets = new ArrayList<CIDR>();
    +        for (Vpc vpc : _vpcDao.listAll()) {
    +            if (_vpcSrvcDao.areServicesSupportedInVpc(vpc.getId(), Service.VPCDynamicRouting))
{
    --- End diff --
    
    For performance reasons, calling a query in a loop should be avoided.  Is it possible
to refactor this ``for`` loop into a join?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message