cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <...@git.apache.org>
Subject [GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...
Date Wed, 11 May 2016 01:57:00 GMT
Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1371#discussion_r62782392
  
    --- Diff: server/src/com/cloud/network/vpc/VpcManagerImpl.java ---
    @@ -705,6 +744,30 @@ public boolean deleteVpcOffering(final long offId) {
         }
     
         @Override
    +    public Map<String, String> updateQuaggaConfig(final Long zoneId, final String
protocol, final String ospfArea, final Short helloInterval, final Short deadInterval,
    +            final Short retransmitInterval, final Short transitDelay, final String authentication,
final String quaggaPassword, final String superCIDR, final Boolean enabled)
    +                    throws BadCIDRException {
    +        OSPFZoneConfig qzc = new OSPFZoneConfig();
    +        DataCenterVO dc = _dcDao.findById(zoneId);
    +        _dcDao.loadDetails(dc);
    +        Map<String, String> details = dc.getDetails();
    +        qzc.setDefaultValues(details);
    +        qzc.setValues(protocol, ospfArea, helloInterval, deadInterval, retransmitInterval,
transitDelay, authentication, quaggaPassword, superCIDR, enabled);
    +        details = qzc.getValues();
    --- End diff --
    
    Given the number of parameters on ``OSPFZoneConfig.setValues`` with the sequence of calls
on lines 754-756, please consider extracting the creation of ``OSPFZoneConfig`` instances
to a builder class as a static inner class on ``OSPFZoneConfig``.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message