cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <...@git.apache.org>
Subject [GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...
Date Wed, 11 May 2016 01:45:16 GMT
Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1371#discussion_r62781709
  
    --- Diff: server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java
---
    @@ -455,16 +471,26 @@ protected void finalizeNetworkRulesForNetwork(final Commands cmds,
final DomainR
     
             super.finalizeNetworkRulesForNetwork(cmds, domainRouterVO, provider, guestNetworkId);
     
    +        final VpcVO vpc = _vpcDao.findById(domainRouterVO.getVpcId());
             if (domainRouterVO.getVpcId() != null) {
    -
                 if (domainRouterVO.getState() == State.Starting || domainRouterVO.getState()
== State.Running) {
                     if (_networkModel.isProviderSupportServiceInNetwork(guestNetworkId, Service.NetworkACL,
Provider.VPCVirtualRouter)) {
                         final List<NetworkACLItemVO> networkACLs = _networkACLMgr.listNetworkACLItems(guestNetworkId);
                         if (networkACLs != null && !networkACLs.isEmpty()) {
    -                        s_logger.debug("Found " + networkACLs.size() + " network ACLs
to apply as a part of VPC VR " + domainRouterVO + " start for guest network id=" + guestNetworkId);
    +                        s_logger.debug(
    +                                "Found " + networkACLs.size() + " network ACLs to apply
as a part of VPC VR " + domainRouterVO + " start for guest network id=" + guestNetworkId);
                             _commandSetupHelper.createNetworkACLsCommands(networkACLs, domainRouterVO,
cmds, guestNetworkId, false);
                         }
                     }
    +                if (_vpcOffServiceDao.areServicesSupportedByNetworkOffering(vpc.getVpcOfferingId(),
Service.VPCDynamicRouting)
    +                        && _networkModel.areServicesSupportedInNetwork(guestNetworkId,
Service.VPCDynamicRouting)) {
    +                    try {
    +                        _commandSetupHelper.createQuaggaConfigCommand(domainRouterVO,
vpc.getId(), cmds);
    +                    } catch (BadCIDRException ex) {
    +                        s_logger.debug(ex);
    +                        throw new CloudRuntimeException("The cidr for dynamic routing
is bad " + ex);
    --- End diff --
    
    Please add the ``ex`` as the cause to provide a complete stack trace for debugging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message