cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <...@git.apache.org>
Subject [GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...
Date Wed, 11 May 2016 01:21:41 GMT
Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1371#discussion_r62780203
  
    --- Diff: engine/schema/src/com/cloud/network/dao/PhysicalNetworkServiceProviderVO.java
---
    @@ -308,15 +331,21 @@ public void setEnabledServices(List<Service> services) {
             if (this.isSecuritygroupServiceProvided()) {
                 services.add(Service.SecurityGroup);
             }
    +        if (this.isDynamicRoutingProvided()) {
    +            services.add(Service.VPCDynamicRouting);
    +        }
             return services;
         }
     
         @Override
    -    public boolean isNetworkAclServiceProvided() {
    -        return networkAclServiceProvided;
    +    public String toString() {
    +        return "PhysicalNetworkServiceProviderVO [id=" + id + ", physicalNetworkId="
+ physicalNetworkId + ", destPhysicalNetworkId=" + destPhysicalNetworkId + ", providerName="
    +                + providerName + ", state=" + state + ", vpnServiceProvided=" + vpnServiceProvided
+ ", dhcpServiceProvided=" + dhcpServiceProvided + ", dnsServiceProvided="
    +                + dnsServiceProvided + ", gatewayServiceProvided=" + gatewayServiceProvided
+ ", firewallServiceProvided=" + firewallServiceProvided + ", sourcenatServiceProvided="
    +                + sourcenatServiceProvided + ", lbServiceProvided=" + lbServiceProvided
+ ", staticnatServiceProvided=" + staticnatServiceProvided
    +                + ", portForwardingServiceProvided=" + portForwardingServiceProvided
+ ", userdataServiceProvided=" + userdataServiceProvided + ", securitygroupServiceProvided="
    +                + securitygroupServiceProvided + ", networkAclServiceProvided=" + networkAclServiceProvided
+ ", dynamicRoutingProvided=" + dynamicRoutingProvided + ", removed="
    +                + removed + "]";
    --- End diff --
    
    Given number of concatenations, please refactor to use a ``StringBuilder`` in order to
reduce the number of strings created.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message