cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From koushik-das <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...
Date Tue, 10 May 2016 11:06:16 GMT
Github user koushik-das commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1518#discussion_r62652337
  
    --- Diff: services/secondary-storage/server/src/org/apache/cloudstack/storage/template/DownloadManagerImpl.java
---
    @@ -984,7 +984,8 @@ public boolean configure(String name, Map<String, Object> params)
throws Configu
             String inSystemVM = (String)params.get("secondary.storage.vm");
             if (inSystemVM != null && "true".equalsIgnoreCase(inSystemVM)) {
                 s_logger.info("DownloadManager: starting additional services since we are
inside system vm");
    -            _nfsVersion = (String)params.get("nfsVersion");
    +            String nfsVersionParam = (String)params.get("nfsVersion");
    +            _nfsVersion = (nfsVersionParam != null ? Integer.valueOf(nfsVersionParam)
: null);
    --- End diff --
    
    Saw this pattern getting repeated in multiple places, if possible move it to a method.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message