cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rhtyd <>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...
Date Tue, 10 May 2016 04:54:14 GMT
Github user rhtyd commented on a diff in the pull request:
    --- Diff: utils/src/main/java/org/apache/cloudstack/utils/process/ ---
    @@ -0,0 +1,112 @@
    +// Licensed to the Apache Software Foundation (ASF) under one
    +// or more contributor license agreements.  See the NOTICE file
    +// distributed with this work for additional information
    +// regarding copyright ownership.  The ASF licenses this file
    +// to you under the Apache License, Version 2.0 (the
    +// "License"); you may not use this file except in compliance
    +// with the License.  You may obtain a copy of the License at
    +// Unless required by applicable law or agreed to in writing,
    +// software distributed under the License is distributed on an
    +// KIND, either express or implied.  See the License for the
    +// specific language governing permissions and limitations
    +// under the License.
    +package org.apache.cloudstack.utils.process;
    +import org.apache.log4j.Logger;
    +import org.joda.time.Duration;
    +import java.util.List;
    +import java.util.concurrent.Callable;
    +import java.util.concurrent.ExecutionException;
    +import java.util.concurrent.ExecutorService;
    +import java.util.concurrent.Executors;
    +import java.util.concurrent.Future;
    +import java.util.concurrent.TimeUnit;
    +import java.util.concurrent.TimeoutException;
    +public class ProcessRunner {
    +    public static final Logger LOG = Logger.getLogger(ProcessRunner.class);
    +    private static final ExecutorService processExecutor = Executors.newCachedThreadPool(new
    --- End diff --
    This is a general utility, so it won't be possible to configure the executor service pool
size here without passing a global setting variable on initialization. The cached pool ensures
to reuse threads and still a better way than spawning separate threads on each run. Wrt oobm,
for each issue command only one thread is spawned that execs an ipmitool process, a maximum
of 250 (or size specified in which forces the size of max. no of concurrent
async jobs) ipmitool processes can be spawned at any given time.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message