cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From syed <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Fix Sync of template.properties in Swift
Date Mon, 09 May 2016 19:56:15 GMT
Github user syed commented on the pull request:

    https://github.com/apache/cloudstack/pull/1331#issuecomment-217971133
  
    @rafaelweingartner @jburwell Sorry for the late reply to this. I was on vacation and returned
today. I've decided to use John's approach for the logging test as I feel it is more natural.
Also the dicussion about `final static` being immutable and skipped by GC makes me feel that
using an appender makes more sense. Furthermore, the `TestAppender` class provided by @jburwell
is generic so that other tests can use it too. 
    
    I will sqash the commits as it looking pretty good now unless you guys have any more comments.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message