cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mike-tutkowski <>
Subject [GitHub] cloudstack pull request: Notify listeners when a host has been add...
Date Mon, 09 May 2016 18:22:20 GMT
Github user mike-tutkowski commented on a diff in the pull request:
    --- Diff: plugins/storage/volume/solidfire/src/org/apache/cloudstack/storage/datastore/provider/
    @@ -91,18 +280,5 @@ public boolean hostConnect(long hostId, long storagePoolId) {
             assert (answer instanceof ModifyStoragePoolAnswer) : "ModifyStoragePoolAnswer
expected ; Pool = " + storagePool.getId() + " Host = " + hostId;
    --- End diff --
    Some like they; some don't. I'd say feel free to put asserts in your code. I don't think
the community has a formal policy on it.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message