cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From syed <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Notify listeners when a host has been add...
Date Mon, 09 May 2016 14:57:30 GMT
Github user syed commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/816#discussion_r62513240
  
    --- Diff: server/src/com/cloud/resource/ResourceManagerImpl.java ---
    @@ -1570,17 +1578,35 @@ private boolean checkCIDR(final HostPodVO pod, final String serverPrivateIP,
fin
             return true;
         }
     
    +    private HostVO isNewHost(StartupCommand[] startupCommands) {
    --- End diff --
    
    Rename to `getNewHost` ?  `isNewHost` sounds like it should return a boolean


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message