cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From syed <>
Subject [GitHub] cloudstack pull request: Notify listeners when a host has been add...
Date Mon, 09 May 2016 14:50:15 GMT
Github user syed commented on a diff in the pull request:
    --- Diff: plugins/storage/volume/solidfire/src/org/apache/cloudstack/storage/datastore/provider/
    @@ -91,18 +280,5 @@ public boolean hostConnect(long hostId, long storagePoolId) {
             assert (answer instanceof ModifyStoragePoolAnswer) : "ModifyStoragePoolAnswer
expected ; Pool = " + storagePool.getId() + " Host = " + hostId;
    --- End diff --
    Off topic but I wanted to know what is the take on asserts? Personally I love asserts
but not sure what the community thinks of it.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message