cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From drsridevi <...@git.apache.org>
Subject [GitHub] cloudstack pull request: DAO: Hit the cache for entity flagged as ...
Date Mon, 09 May 2016 09:07:20 GMT
Github user drsridevi commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1532#discussion_r62469111
  
    --- Diff: framework/db/src/com/cloud/utils/db/GenericDaoBase.java ---
    @@ -969,7 +969,12 @@ public T findByUuidIncludingRemoved(final String uuid) {
         @Override
         @DB()
         public T findByIdIncludingRemoved(ID id) {
    -        return findById(id, true, null);
    +        if (_cache != null) {
    +            final Element element = _cache.get(id);
    +            return element == null ? findById(id, true, null) : (T)element.getObjectValue();
    +        } else {
    --- End diff --
    
    @DaanHoogland following code returns null if _cache is not null but element is null,
    >`
    T result = null
    if (_cache != null) {
        final Element element = _cache.get(id);
        if (element != null) {
            result = (T)element.getObjectValue();
        }
    } else {
        result =findById(id, true, null);
    }
    return result;
    `



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message