cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ntavares <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Honour GS use_ext_dns and redundant VR VI...
Date Sat, 07 May 2016 15:57:38 GMT
Github user ntavares commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1535#discussion_r62418187
  
    --- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsConfig.py ---
    @@ -68,8 +68,11 @@ def get_domain(self):
     
         def get_dns(self):
             dns = []
    -        # Check what happens with use_ext_dns
    -        dns.append(self.address().get_guest_ip())
    +        if not self.cl.get_use_ext_dns():
    +            if not self.is_vpc() and self.cl.is_redundant():
    +                dns.append(self.cl.get_guest_gw())
    +            elif not self.cl.get_use_ext_dns():
    --- End diff --
    
    @DaanHoogland you're right... cleaned it up.. thanks for spotting it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message