cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9099: SecretKey is returned fr...
Date Fri, 06 May 2016 14:31:29 GMT
Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1152#discussion_r62337172
  
    --- Diff: server/test/com/cloud/user/MockAccountManagerImpl.java ---
    @@ -401,5 +403,24 @@ public Long finalyzeAccountId(String accountName, Long domainId,
Long projectId,
             return null;
         }
     
    +    @Override
    +    public List<String> getKeys(GetUserKeysCmd cmd) {
    +        return null;
    +    }
    +
    +    @Override
    +    public void checkAccess(User user, ControlledEntity entity)
    +        throws PermissionDeniedException {
    +
    +    }
    +    @Override
    +    public String getConfigComponentName() {
    +        return null;
    +    }
    +
    +    @Override
    +    public ConfigKey<?>[] getConfigKeys() {
    +        return null;
    --- End diff --
    
    Please return an empty array to avoid NPEs.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message