cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9099: SecretKey is returned fr...
Date Fri, 06 May 2016 14:29:41 GMT
Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1152#discussion_r62336941
  
    --- Diff: server/src/com/cloud/user/AccountManager.java ---
    @@ -198,4 +200,11 @@ void buildACLViewSearchCriteria(SearchCriteria<? extends ControlledViewEntity>
s
         public static final String MESSAGE_ADD_ACCOUNT_EVENT = "Message.AddAccount.Event";
     
         public static final String MESSAGE_REMOVE_ACCOUNT_EVENT = "Message.RemoveAccount.Event";
    +    public static final ConfigKey<Boolean> UseSecretKeyInResponse = new ConfigKey<Boolean>(
    +            "Advanced",
    +            Boolean.class,
    +            "use.secret.key.in.response",
    +            "true",
    --- End diff --
    
    @kansal I agree with @DaanHoogland and @remibergsma -- it's about reasonable and secure
defaults.  We should not configure a management server insecurely by default.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message