cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...
Date Fri, 06 May 2016 13:34:29 GMT
Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1514#discussion_r62329838
  
    --- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsDhcp.py ---
    @@ -54,7 +54,8 @@ def process(self):
             self.cloud.commit()
     
             # We restart DNSMASQ every time the configure.py is called in order to avoid
lease problems.
    -        CsHelper.service("dnsmasq", "restart")
    +        if not self.cl.is_redundant() or self.cl.is_master():
    --- End diff --
    
    Would is make sense for the ``is_redundant()`` check to be in the ``is_master()`` method?
 To my way of thinking, any non-redundant router is a de facto master.  
    
    I understand such a change may be too far to be practical at this time, so we may want
to table it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message