cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <>
Subject [GitHub] cloudstack pull request: Convert patchviasocket to python (removes...
Date Fri, 06 May 2016 13:24:17 GMT
Github user jburwell commented on a diff in the pull request:
    --- Diff: scripts/vm/hypervisor/kvm/ ---
    @@ -0,0 +1,142 @@
    +#!/usr/bin/env python
    +# Licensed to the Apache Software Foundation (ASF) under one
    +# or more contributor license agreements.  See the NOTICE file
    +# distributed with this work for additional information
    +# regarding copyright ownership.  The ASF licenses this file
    +# to you under the Apache License, Version 2.0 (the
    +# "License"); you may not use this file except in compliance
    +# with the License.  You may obtain a copy of the License at
    +# Unless required by applicable law or agreed to in writing,
    +# software distributed under the License is distributed on an
    +# KIND, either express or implied.  See the License for the
    +# specific language governing permissions and limitations
    +# under the License.
    +import patchviasocket
    +import getpass
    +import os
    +import socket
    +import tempfile
    +import time
    +import threading
    +import unittest
    +KEY_DATA = "I luv\nCloudStack\n"
    +CMD_DATA = "/run/this-for-me --please=TRUE! very%quickly"
    +NON_EXISTING_FILE = "must-not-exist"
    +def write_key_file():
    +    tmpfile = tempfile.mktemp(".sck")
    +    with open(tmpfile, "w") as f:
    +        f.write(KEY_DATA)
    +    return tmpfile
    +class SocketThread(threading.Thread):
    +    def __init__(self):
    +        super(SocketThread, self).__init__()
    +        self._data = ""
    +        self._file = tempfile.mktemp(".sck")
    +        self._ready = False
    +    def data(self):
    +        return self._data
    +    def file(self):
    +        return self._file
    +    def wait_until_ready(self):
    --- End diff --
    Should this be bounded by a maximum wait time?  For example, if the ulimits are exceeded,
this function could turn into an infinite loop.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message