cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...
Date Fri, 06 May 2016 12:14:35 GMT
Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1502#discussion_r62321985
  
    --- Diff: server/src/com/cloud/server/StatsCollector.java ---
    @@ -412,6 +428,36 @@ protected void runInContext() {
             }
         }
     
    +    class HostOutOfBandManagementStatsCollector extends ManagedContextRunnable {
    +        @Override
    +        protected void runInContext() {
    +            try {
    +                s_logger.debug("HostOutOfBandManagementStatsCollector is running...");
    +                List<OutOfBandManagementVO> outOfBandManagementHosts = outOfBandManagementDao.findAllByManagementServer(ManagementServerNode.getManagementServerId());
    +                if (outOfBandManagementHosts == null) {
    +                    return;
    +                }
    +                for (OutOfBandManagement outOfBandManagementHost : outOfBandManagementHosts)
{
    +                    Host host = _hostDao.findById(outOfBandManagementHost.getHostId());
    +                    if (host == null) {
    +                        continue;
    +                    }
    +                    if (outOfBandManagementService.isOutOfBandManagementEnabled(host))
{
    +                        outOfBandManagementService.submitBackgroundPowerSyncTask(host);
    +                    } else {
    +                        if (outOfBandManagementHost.getPowerState() != OutOfBandManagement.PowerState.Disabled)
{
    +                            if (outOfBandManagementService.transitionPowerStateToDisabled(Collections.singletonList(host)))
{
    +                                s_logger.debug("Out-of-band management was disabled in
zone/cluster/host, disabled power state for host id:" + host.getId());
    --- End diff --
    
    Please wrap in a ``if (LOGGER.isDebugEnabled)`` check.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message